fix: do not allow autodial to run in parallel #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
fix/do-not-allow-autodial-to-run-in-parallel
branch
from
5c8b3fa
to
6f23d51
Compare
Auto dial attempts to keep the number of active connections above a configurable minimum, but dialling is slow so the dial queue can grow quite large. If unchecked this can cause OOMs. - Adds a `running` boolean to the autodialler to prevent it running in parallel. - Adds a configurable limit for the auto dial and circuit relay reservation queue lengths Fixes #1800 Fixes ipfs/helia#143
achingbrain
force-pushed
the
fix/do-not-allow-autodial-to-run-in-parallel
branch
from
6f23d51
to
c8eb517
Compare
|
Merging because this solves a very real problem though I'd still like a review.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto dial attempts to keep the number of active connections above
a configurable minimum, but dialling is slow so the dial queue can
grow quite large. If unchecked this can cause OOMs.
runningboolean to the autodialler to prevent it runningin parallel.
Fixes #1800
Fixes ipfs/helia#143